"Leslie P. Polzer" <[email protected]> writes: > Some changes that need to be made: > > * you forgot to export *default-restart* > > * the documentation for *default-restart* should be a docstring > instead of a code comment > > * I think we still need *catch-errors-p* to be able to pass on > handling of a signal outside of the Weblocks handler (for example in > the test case `allow-restart-in-sessinit')
Thanks for pointing them out, I'll change the code asap. > * the indentation level in handle-client-request is too much now, > and the PROGN is pretty ugly. Let's separate it into two functions. Yes, initially the restart code was in the around method of `handle-request-handler', but IIRC the code in therestart `rehandle-request' complained something about the `*current-webapp*' special variable, so I moved the restart code where it is now, leaving the handler binding code in the around method. But then, I had trouble accessing the condition variable in the `show-backtrace' restart when this restart is called interactively by the debugger, so I put also the `handler-bind' macro call in `handle-client-request'. Just some minutes ago, I asked Peter Seibel (all I know about the condition/restart system in CL comes from his book) in the #lisp irc channel if there is a simple way to pass the condition signaled from the handler to the restart code when the restart is called from the debugger and he replied that it could be implementation dependant. Anyway, I will try to find a reasonably solution to this problems and will then send a patch. In the meantime, thank you for your help, Andrea. -- Reclama i tuoi diritti digitali, elimina il DRM. Approfondisci su http://www.no1984.org Reclaim your digital rights, eliminate DRM. Learn more at http://www.defectivebydesign.org/what_is_drm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "weblocks" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/weblocks?hl=en -~----------~----~----~----~------~----~------~--~---
