Mackram wrote: > > Okay so i have written the lisp code and tried running it through the > old patch of tests that is there (I am not done with a test file for > this specific patch yet) and I have a few comments to make: > > 1- I have had to modify a couple of tests so that they continue to > behave in the default manner. Specifically in the old version > prototype is added by default with the new version we can not add > anything by default since you would have to specify its files. > Accordingly I have had to add an extra argument for the webapp in the > cases where it was tested. > > 2- In some tests where bundling is compared the script hierarchy is > hardcoded into the test and for us to move the scripts to a more > appropriate location would require the change of these tests as well.
Those two changes are perfectly alright. > 3- I have had only 3 failures in all the tests and they are all under > handle-request.lisp. Specifically I am having trouble with handle- > client-request-6, handle-client-request-7 (in both these cases I get > result 1 when 2 is expected) and handle-client-request-10 (I get the > result "nil" when the result expected is "http://nil/?weblocks- > session=1%3atest"). My question is can anyone point me on to what > these are trying to test specifically? It's unfortunate that the tests are just numbered instead of having a descriptive name. I've glossed over them: HCR-6 tests PRE-RENDER and POST-RENDER session hooks. HCR-7 tests PRE-ACTION and POST-RENDER request hooks. HCR-10 tests PRE-ACTION and POST-ACTION session hooks and simple action handling. For 6 and 7 (and maybe the second value of 10 too) you need to check why the hooks don't get run. For 10 check where redirects happen (or where they don't but should). Also check manually whether a request of the form http://server/?action=foo causes a redirect. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "weblocks" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/weblocks?hl=en -~----------~----~----~----~------~----~------~--~---
