On Thursday October 29 2009 03:14:28 Petr Sumbera wrote: > Brian Overstreet napsal(a): > > On Thursday 22 October 2009 07:04:54 Petr Sumbera wrote: > >> Brian Overstreet wrote: > >>> On Friday October 9 2009 06:25:40 Petr Sumbera wrote: > >>>> Hi, > >>>> > >>>> can somebody please review following changes to Solaris Nevada Tomcat? > >>>> > >>>> 6864292 [nvb119] some JSP and SERVLET functional tests are failed > >>>> (strict_servlet compliance) > >>>> 6878859 Tomcat should create pid file for monitoring by other > >>>> applications 6890019 Tomcat packaging should better support custom > >>>> ROOT web > >>>> application deployment > >>>> 6889510 tomcat 6 is built with wrong version info > >>>> > >>>> http://cr.opensolaris.org/~xsumbe00/6890019-tomcat/ > >>> > >>> The changes look good to me. > >>> +1 > >> > >> Thanks for looking at this! I had to update changes. Can you please look > >> at updated webrev? > > > > I have one question about the pid file. Would it be better if the PID > > was named catalina.pid instead of just pid? This would be more > > consistent with the log name of catalina.out and also other pid files in > > the system with the format of {progname}.pid. > > Since pid file location is now /var/tomcat6/logs/pid, I believe it's > clear that it's Tomcat pid file (no need to mention Catalina). > > I would prefer to leave it as it's now since PSARC/2009/563 which > defines this location is already approved (and the idea of PID file was > very controversial). Since this is the case, that's fine. I was just throwing out a suggestion based on the log file name. So the changes look good.
--Brian > > Thanks, > > Petr >
