Rahul thanks for looking into the webrev. rahul wrote: >> We would like to integrate MCrypt extension and implement some of the >> PHP enhancements mentioned within LSARC/2009/124 ARC case like adding >> hook up for sun web server 7 and ability to provide statistics for APC >> and Memcache within build 110. Can you please review my webrev and >> provide your valuable feedback. >> http://cr.opensolaris.org/~sn123202/php529.feb26/ >> >> Though, this web rev does not contain changes pertaining to 5.2.9 >> integration, I hope to commit 5.2.9 as a separate putback. I am still >> waiting for that RTI to be approved. >> >> Note: We are currently unable to complete adding DTrace probes within >> PHP engine for build 110 and I guess, hopefully we will be allowed to >> integrate within build 111. >> >> > > > http://cr.opensolaris.org/~sn123202/php529.feb26/usr/src/cmd/php5/Makefile.sfw.udiff.html > nitpicks :) > 1) perhaps you can use $(SHELL) to invoke configure? > this has been like that since php 5.2.4. I would probably make the change in the next putback. Probably okay with you. > 2) why use /usr/ucb/install and _install function both? > > I use /usr/ucb/install on Makefile.sfw and _install within install-php5 (shell script). > I am totally missing what changed in these :( .. > > http://cr.opensolaris.org/~sn123202/php529.feb26/usr/src/cmd/php5/patches/php_Makefile.global.patch.udiff.html > http://cr.opensolaris.org/~sn123202/php529.feb26/usr/src/cmd/php5/patches/php_dl.c.patch.udiff.html > http://cr.opensolaris.org/~sn123202/php529.feb26/usr/src/cmd/php5/patches/php_ini.patch.cdiff.html > http://cr.opensolaris.org/~sn123202/php529.feb26/usr/src/cmd/php5/patches/php_run-tests.php.patch.udiff.html > > These changes only reflect that the patches have been applied for 5.2.9.
- Sriram > ---~*~--- > rahul > -- > 1. e4 _ > >
