Sriram Natarajan wrote: > > > Amanda Waite wrote: >> usr/src/cmd/php5/METADATA >> - Clean up indentation >> > anything particular ? First line, in the webrev as displayed in my browser 'php' isn't aligned with the ones underneath
>> usr/src/pkgdefs/SUNWphp52u/prototype_com >> - Don't set the write bit on new files going into /usr >> > Which particular file did you notice with 'write' bit set . I thought, > I took care of this issue My bad, they were directories with file like names. Ignore that comment. So it looks fine, I'll leave you to fix up the METADATA file, no need to repost the webrev (for me at least). Amanda > > - Sriram >> Otherwise it looks fine >> >> BTW: I was also confused by the changes to the patch files, but the >> changes look ok. Also make a note to tidy up the CDDL headers of any >> changed files in future updates >> http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/ >> >> >> Amanda >> >> >> Sriram Natarajan wrote: >>> Paul >>> Please find the updated webrev with the changes that you requested >>> included >>> http://cr.opensolaris.org/~sn123202/php529.feb26/ >>> >>> thanks >>> sriram >>> >>> Paul Cunningham wrote: >>>> Note, I haven't reviewed this, but I noticed you haven't updated >>>> the METADATA file (or you need to add one) Then extract the >>>> PHP_VER= info (in Makefile.sfw) from the METADATA. >>>> >>>> paul >>>> >>>> Sriram Natarajan wrote: >>>>> Hi >>>>> We would like to integrate MCrypt extension and implement some of >>>>> the PHP enhancements mentioned within LSARC/2009/124 ARC case like >>>>> adding hook up for sun web server 7 and ability to provide >>>>> statistics for APC and Memcache within build 110. Can you please >>>>> review my webrev and provide your valuable feedback. >>>>> http://cr.opensolaris.org/~sn123202/php529.feb26/ >>>>> >>>>> Though, this web rev does not contain changes pertaining to 5.2.9 >>>>> integration, I hope to commit 5.2.9 as a separate putback. I am >>>>> still waiting for that RTI to be approved. >>>>> >>>>> Note: We are currently unable to complete adding DTrace probes >>>>> within PHP engine for build 110 and I guess, hopefully we will be >>>>> allowed to integrate within build 111. >>>>> >>>> >>>> >>> _______________________________________________ >>> sfwnv-discuss mailing list >>> sfwnv-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >>
