Sunanda Menon wrote:
>
> I would like the changes to be reviewed at 
> http://cr.opensolaris.org/~sunandam/6634053
> Please let me know your comments latest by Tuesday 11th March EOD.

In Makefile.sfw, CXX64FLAGS and CXX32FLAGS show some duplication of
flags and both ENVLINE and ENVLINE64 again repeat some of the same
flags.  That's setting up quite a maintenance trap where someone will
update one of the four but miss any or all of the other three.  Please
factor out all the commonality into shared vars and add specific
extras to that common set only where needed, so a given flag isn't
repeated.

-.\" ident       "@(#)mysql.1    1.1     07/01/02 SMI"
+.\" ident   "@(#)mysql.1.sunman 1.4     08/03/09 SMI"
redelget missing?




-- 
Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems

Reply via email to