Seema Alevoor wrote: > > Hi, > > Please review the fix for CR 6653066. > WebRev is at http://cr.opensolaris.org/~seema/6653066/
Thanks for testing dependencies like svn.. Maybe also do some testing with a minimal PHP page as well, if you haven't already. I don't see why there should be any problem but for the sake of completeness. usr/src/cmd/apache2/apache.build.env: usr/src/pkgdefs/SUNWapch22d/prototype_com: usr/src/pkgdefs/SUNWapch22u/prototype_i386: usr/src/pkgdefs/SUNWapch22u/prototype_sparc: usr/src/pkgdefs/SUNWapch22u/prototype_com: (I might've missed some, so check in all changed files) - all the above need copyright date update (2008) usr/src/cmd/apache2/patches/apachectl.patch: usr/src/cmd/apache2/patches/apachectl.patch.64: (and in several other patch files): - might be easier to make the patches relative to the source dir to save some effort like this where nothing changed except dir name. You'll also need an ARC case to document the version change in both Apache and APR. As nothing else of substance is changing I expect it to be an automatic case. Send me a doc and I'll file it today. Aside from Apache & APR version change, I see there's a new mod_substitute.so added by 2.2.8, so you should briefly (1 sentence) mention it (what is it?) -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
