Sivakumar Shanmugasundaram wrote:
>
> Hello!
>
> Please review the code changes for the following CRs as mentioned in the
> webrev below. Thanks.
> The sparc build does not include DTrace probes because the CR 6659110
> causes sparc default (optimized) build to fail. There is a workaround to
> have a debug build (-g ONLY) of Ruby with DTrace probes. But the Ruby
> benchmarks show a performance degradation of about 30% (Yes average of
> 30% across the benchmarks) over an optimized (non-dtrace enabled) sparc
> build.
>
> 6632022 ruby dtrace support
> 6635728 SUNWruby18u packaging issues with snv_78.
>
> http://cr.opensolaris.org/~ss39446/webrev2/webrev/
usr/src/cmd/ruby18/Makefile.sfw:
- Update copyright year (2008)
- The new file shows version 1.1 in the ident line (same as previous
version), so there is something wrong in the versioning of your files.
Correct that before putback.
- I'm not so sure about diverging the features on x86 vs. SPARC...
- Which ARC case covers these new interfaces? Is it filed yet?
usr/src/pkgdefs/SUNWruby18u/depend:
- Update copyright year (2008)
- In the change comments, include only those bugs which are relevant
to the changes made in a given file. The diffs in this file seem
to me to be all related only to 6635728, and not related to 6632022.
So, list only 6635728 in the change comments for this file.
- Here also something wrong with ident line, doesn't show updated version.
usr/src/pkgdefs/SUNWruby18u/prototype_i386.tmpl:
- Update copyright year (2008)
- As above, but here the change seems to be related only to 6632022,
so list only that bug#.
- Here also something wrong with ident line, doesn't show updated version.
usr/src/cmd/ruby18/patches/ruby-dtrace-1.8.6.patch:
- Is it identical to the upstream patch or did you need to make any
local changes?
--
Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
