Sivakumar Shanmugasundaram wrote:
>
> Jyri,
> 
> Thanks for your code feedback.
> I have these files in checked out state (thats why the ident line will 
> say '%Z%' and such and does not echo the actual version yet). This is a 
> practice from my old dev team. May be I should checkin before submitting 
> for review?

Yes please do the sccs delget (as well as wx ea; wx redelget) before
generating the webrev. Otherwise you'll always get a lot of the same
comments..

> I have updated the copyright years to 2008 now.

Thanks..

> Regarding the patch, there were a couple of changes related to the 
> makefile/configure.in scripts. No change to the code (.c/.d/.h) files 
> were done.

Sounds good.

Please regenerate and repost the webrevs whenever they're ready.

Looks like the only thing pending is the [very short] ARC case to
document the new interfaces (the dtrace probe names being introduced).
Send me a draft and I can sponsor it.


-- 
Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems

Reply via email to