Hi Jyri, Thanks for your feedback. Kindly see my response inline.
Regards, Ritu Jyri Virkki wrote: >Ritu Kamboj wrote: > > >>Hi, >> >>Kindly find the webrev for MySQL integration at : >> >>http://cr.opensolaris.org/~rkamboj/MySQLWebRev/ >> >> > >The comments are all still "NO COMMENT" - see wx ea/wx redelget. > > Prior to checking in ,shall update the comment to "Integrate MySQL with Build-79" >/usr/src/cmd/Makefile >- Adds mysql-5-0 but older mysql still there? > > Yes, the older version of mysql will remain as is ..I am just adding a new version of mysql >Solaris/mysql.1.sunman >- Should add the boilerplate > "Source for mysql is available on http://opensolaris.org"; > in the NOTES section (see other sfw components for examples) > > done >SUNWmysql5r/prototype_com > 63 f none var/svc/manifest/application/database/mysql.xml 0444 root sys >should be "manifest" instead of "none" right? And see CR 6625975 for gotchas. > > Was not aware of this ...thanks for pointing this to me ...made the necessary change >SUNWmysql5r/depends > - Looking at files I noticed dependencies on SUNWlibmsr,SUNWzlib > >copyright files: > As it mentions [L]GPL it probably needs the Sun preamble - but check > with cteam on this. > > I have updated the copyright infor based on feedback from Stefan Teleman > > > >
