Ritu Kamboj wrote: > > I have updated webrev; > > http://cr.opensolaris.org/~rkamboj/MySQLWebRev/
usr/src/cmd/mysql-5-0/Makefile.sfw: In the option list for ./configure, the convention is to sort them alphabetically. Makes changes easier later. usr/src/cmd/mysql-5-0/Solaris/mysql: 40 #set your root password here 41 password=""; First, this is not a user editable file so it can't have editable content. Aside from that, a password certainly doesn't belong there! What's the intent? It's only used by stop. mysql_restart() sleeps until the process disappears. Doesn't this hang forever if the process doesn't exit gracefully for whatever reason? Look at /lib/svc/method/nfs-server for an alternative which seems more reliable? usr/src/pkgdefs/SUNWmysql5r/prototype_com: The config file needs to be editable "e renamenew" instead of "f none" (and then the CLASSES needs to have renamenew as well) 49 f none etc/mysql/5.0/my.cnf 0644 root bin -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
