Roland Mainz wrote: > > Please use [...] I'd find it useful it you could state comments in terms of the reasoning behind them, not just the end result. That would convey more info and be a lot more educational..
Instead of "Please use ____", I'd prefer to see something along the lines of "Your current code _____ will break when _____ and _____ happens, you can fix this by using ______ instead" or some such explanation. TIA.. > General note for this type of script: Please add a $ set -o errexit # at > the beginning that the script - the "errexit" flag causes the shell to > immediately abort the script when it hits a command which returns a > failure instead of continuing operation (and maybe running amok (or > worse) ...) There was some discussion on this topic back in: http://www.opensolaris.org/jive/thread.jspa?threadID=44599&tstart=0 but it appears inconclusive. Instead of every build piece doing something different, there needs to be consistency. Is there an existing rule or convention for SFW here? If not, we should discuss and decide on one. -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
