Hi Sunanda,

usr/src/cmd/mysql-5-0/METADATA

- Can you add a NAME field as per 
http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines


usr/src/cmd/mysql-5-0/Makefile.sfw

- You can get Version numbers and Program names from the METADATA file. 
These are available as

$(COMPONENT_NAME:sh)
$(COMPONENT_VERSION:sh)

It would be good to use at least the VERSION field, then it only needs 
to be changed once for future updates.

 - You could also use $(SHELL) in place of ksh93 when invoking the 
install-sfw* scripts

Everything else looks good.

Thanks

Amanda


sunanda menon wrote:
> Hi ,
> Please do a Code Review request for the upgrade of MySQL from 5.0.67 
> to 5.0.77 (CR 6808952)
> at http://cr.opensolaris.org/~sunandam/6808952/
>
> Thanks Sunanda
> _______________________________________________
>
>
> webstack-discuss mailing list
> webstack-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss


Reply via email to