usr/src/cmd/mysql-5-0/Makefile.sfw :
    I don't think there is a need to explicitly include "/usr/include/openssl" 
in the CFLAGS/CXXFLAGS.
--with-openssl-includes should suffice. Anyway, it isn't a major issue.

So, changes look fine to me.

-- Seema.

On 03/18/09 11:57, sunanda menon wrote:
> Updated webrevs posted at http://cr.opensolaris.org/~sunandam/6808952/
> 
> Thanks Sunanda
> 
> Seema Alevoor wrote:
>> usr/src/cmd/mysql-5-0/Makefile.sfw :
>>     * Use $(CCBITS64) instead of "-m64"
>>     * CXX64FLAGS already includes "-m64" . So, there is no need to add 
>> this flag again to CXXFLAGS.
>>
>> -- Seema.
>>
>>
>> On 03/12/09 17:17, sunanda menon wrote:
>>> Hi ,
>>> Please do a Code Review request for the upgrade of MySQL from 5.0.67 
>>> to 5.0.77 (CR 6808952)
>>> at http://cr.opensolaris.org/~sunandam/6808952/
>>>
>>> Thanks Sunanda
>>> _______________________________________________
>>>
>>>
>>> webstack-discuss mailing list
>>> webstack-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
> 

Reply via email to