On Friday 04 December 2009 01:05:01 Jyri Virkki wrote: Thanks for looking at this Jyri. The webrev has been updated based on your feedback. I also updated the usr/src/Targetdirs file in this new webrev because not all directories were listed in that file.
> On Dec 4, 2009, at 12:05 AM, Brian Overstreet wrote: > > Please review and provide comments for > > > > CR 6903263: Integrate collectd 4.8.1 into SFW > > > > WebRev URL: http://cr.opensolaris.org/~overstre/6903263/webrev/ > > usr/src/lib/Makefile > The dirs are supposed to be in sorted order, so add the dir where it > goes alphabetically, not at the end. Parts of the list are in alpabetical order, but other parts are not. I've added collectd4 to the first section of the list that is in alphabetical order. > > usr/src/pkgdefs/SUNWcollectd4r/i.renamenew > Don't include a copy, the Makefile is already inheriting one from the > common_files I've uncreated this file. > > usr/src/pkgdefs/SUNWcollectd4r/pkginfo > This file is not checked in, only the .tmpl one > Both the pkginfo and pkginfo.tmpl appear checked in. Did I misss something?
