On Friday 04 December 2009 13:42:05 Jyri Virkki wrote:
> On Dec 4, 2009, at 12:28 PM, Brian Overstreet wrote:
> >> The dirs are supposed to be in sorted order, so add the dir where it
> >> goes alphabetically, not at the end.
> >
> > Parts of the list are in alpabetical order, but other parts are
> > not. I've
> > added collectd4 to the first section of the list that is in
> > alphabetical order.
>
> Close enough. It's "supposed" to be ordered but I guess not everyone
> has followed that.
>
> >> usr/src/pkgdefs/SUNWcollectd4r/pkginfo
> >> This file is not checked in, only the .tmpl one
> >
> > Both the pkginfo and pkginfo.tmpl appear checked in. Did I misss
> > something?
>
> I guess you accidentally added (sccs create) it somewhere along the
> line. The pkginfo file is actually created at build time from
> pkginfo.tmpl, so only the tmpl file belongs in the sources.
My mistake. I have uncreated these files and updated the webrev.
>
>
> Have the patches been contributed to the upstream collectd community
> yet?
Not that I am aware of from looking at the mailing list, source code
repository, or the bug tracker. However, I believe they will be contributed
back to the upstream community when Amit returns from vacation.
>
