Stuart Donaldson wrote: > On the ThreadedAppServer subclassing, I have only done what I > think is a > quick hack right now, adding the class as a parameter to run. > I think a > nicer more OO solution would be to remove run, and replace it with a > start() method on AppServer, along with placing the AppServer stop > function on the AppServer class such that it behaves like a static > method. This allows subclasses to override the start and stop > behavior > as well. > > Then, of course, the other change to fully implement this, is > to modify > Launch.py, so that a user specified AppServer can be passed > in, that is > not necessarily part of WebKit. I am working on the > assumption that an > installed WebKit directory is not writeable by a user, and that they > should be able to create their own subclassed AppServer derived from > ThreadedAppServer. > > If you agree that going this extra route would be a good > thing, then let > me know and I'll give it a shot. For my immediate needs, the hack I > made to the run function will allow subclassing of ThreadedAppServer, > but not in a very elegant manner.
It seems like a good thing. I can't say that I'd actually use it myself, and I'm not sure how many others would use it either. You can decide whether it's worth your while to do the work. - Geoff ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Webware-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/webware-devel
