On 3/23/07, Christoph Zwerschke <[EMAIL PROTECTED]> wrote:
> Chuck Esterbrook wrote:
> > On 3/23/07, Christoph Zwerschke <[EMAIL PROTECTED]> wrote:
> >> I recently stumbled over the following lines in ThreadedAppServer:
> >>
> >> def makeInput(self):
> >> return self._sock.makefile("rb",8012)
> >>
> >> Is there any reason why the number 8012 was chosen? I assume the intend
> >> was to use an 8192 Byte (8k) buffer, and this is just a typo, or am I
> >> overlooking something and the number has a particular reason?
> >
> > I can't relate that number to anything. Also, it seems like it should
> > be a config setting.
>
> Apropos config settings, there is this passage already:
>
> DefaultConfig = {
> ...
> # @@ 2000-04-27 ce: None of the following settings are implemented
> # 'RequestQueueSize': 16,
> # 'RequestBufferSize': 64*1024,
> # 'SocketType': 'inet', # inet, unix
> }
>
> So should we use RequestBufferSize for this?
>
> And while we are at it, we could also implement RequestQueueSize.
>
> Currently the app server uses the following setting:
>
> self._requestQueue = Queue.Queue(self._maxServerThreads * 2)
>
> This makes sense, so instead of an absolute number, we could make
> RequestQueueSize relative to MaxServerThreads, with a default of 2?
All sounds good except I wonder if making it relative to threads is
worthwhile the level of indirection. We can just default it to twice
the size. But I leave it up to you. Maybe there's something I'm
missing.
I guess it would be silly if the queue size was less than max threads
so then we should print a warning or stick with the factor.
-Chuck
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Webware-devel mailing list
Webware-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/webware-devel
