Hello Jerome, I was looking through the refactoring (and it looks much cleaner)
A few thoughts (please take them as such as I did a super quick scan only): 1) Where have actions like phSubscribe and phDTMF gone? I do think those are important other actions that should not be eliminated from access. 2) I would suggest that the object free functions take a pointer to the pointer so that the pointer can be set to NULL immediately inside the function. This eliminates some types of reuse errors. In fact, it would most likely be best to adopt a "Handle" based architecture where the API does not give out the object (I'm not sure how feasible that is). 3) on the same note, the callbacks could potentially be non-blocking in the case that they do not require a return value (a notify for example) so that the api keeps ticking even if the app is badly behaved. 4) The eXosip stack does not accept NOTIFY without SUBSCRIBE. This is bad when connecting to an asterisk box and wanting to get voicemail notification (asterisk sends regardless. This is handled lower in the eXosip stack of course.) [I've made modifications to support the asterisk notify if someone wants to incorporate them]. -Lukas Lukas Oberhuber -----Original Message----- Message: 7 Date: Mon, 16 Oct 2006 20:18:43 +0200 From: J?r?me WAGNER <[EMAIL PROTECTED]> Subject: [Wengophone-devel] branches and wifo-refactoring To: <wengophone-devel@lists.openwengo.com> Message-ID: <[EMAIL PROTECTED]> Content-Type: text/plain; charset="iso-8859-1" Hello, As a side project that begun some weeks ago, I asked Minh to review phapi.h and see how we could leverage our 2 year anniversary of SIP problems and revamp it in order to make a more clear, more easy to understand and less prone to error interface. Some of you may have followed this work in the wifo-refactoring branch. Please look at some entry points and comment : New Ones: http://dev.openwengo.com/trac/openwengo/trac.cgi/browser/wengophone-ng/branc hes/wifo-refactoring/phapi/phapi.h http://dev.openwengo.com/trac/openwengo/trac.cgi/browser/wengophone-ng/branc hes/wifo-refactoring/phapi/phevents.h http://dev.openwengo.com/trac/openwengo/trac.cgi/browser/wengophone-ng/branc hes/wifo-refactoring/phapi/phvline.h Old One: http://dev.openwengo.com/trac/openwengo/trac.cgi/browser/wengophone-ng/trunk /wifo/phapi/phapi.h Minh will try and summarize your comments to take into account your needs in this revamping process. Thank you, Jirtme Ps1: Just to be more precise : this does not put on hold the necessity we have to clarify the repository layout and packaging of wengophone 2.0 on which we will have to work in the next days. It is a crucial refactoring that we need to do before it is too late and that will impact in the mid-term current phapi users so I want to give it sufficient publicity so that everyone can be involved. Ps2: A porting guide will be written to help users understand the new API and help them upgrade their application. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://dev.openwengo.com/pipermail/wengophone-devel/attachments/20061016/0bd 9bf29/attachment-0001.htm ------------------------------ Message: 8 Date: Mon, 16 Oct 2006 20:22:29 +0200 From: J?r?me WAGNER <[EMAIL PROTECTED]> Subject: [Wengophone-devel] wengophone, branches and all To: <wengophone-devel@lists.openwengo.com> Message-ID: <[EMAIL PROTECTED]> Content-Type: text/plain; charset="iso-8859-1" Hello, I added a page recently in the wiki that I thought would need a bit more publicity : http://dev.openwengo.com/trac/openwengo/trac.cgi/wiki/WengoPhoneNGBranches You will find on it an (I hope) up to date map of the branches of wengophone NG. I didnt take time to document all of them so I added a n.a. but this is where you will find the most up to date information from now on since I will use it to document all of the branches/tags process. I hope this helps, Jerome -------------- next part -------------- An HTML attachment was scrubbed... URL: http://dev.openwengo.com/pipermail/wengophone-devel/attachments/20061016/445 ccd4f/attachment.html ------------------------------ _______________________________________________ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel End of Wengophone-devel Digest, Vol 15, Issue 33 ************************************************ _______________________________________________ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel
