On Wednesday 12 September 2007 00:19:57 neocoretech wrote:
> Hello OpenWengo-Devs,
>
> As I want to participate in the OpenWengo-Project I looked around in the
> rookie tickets and found one I thought I could manage
> (#1735 WengoPhone 2.2 not honoring the linux.prefered.browser Value set
> in Advanced Configuration).
Hello Dominic, welcome aboard!
Thanks for the patch, but I I don't really like the fact that we need to
modify all calls to WebBrowser::openUrl(). That's why I would like to suggest
a different approach (I hope you don't mind):
1. Add a static method to WebBrowser to define the browser. Something like
this:
class WebBrowser {
...
static void setBrowser(const std::string& browser);
...
};
This static method would store the browser value in a static string, which
would be checked by linux_open_url() if set.
2. in main() (wengophone/src/presentation/main.cpp):
Call WebBrowser::setBrowser() after config has been loaded.
3. In QtAdvancedConfig::saveConfig()
(wengophone/src/presentation/qt/config/QtAdvancedConfig.cpp):
Check if the linux.prefered.browser has been modified, and in this case call
WebBrowser::setBrowser().
Can you try to do this?
Aurélien
_______________________________________________
Wengophone-devel mailing list
[email protected]
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
