On Wednesday 12 September 2007 17:48:57 neokortex wrote: > Good Evening, > > you're completely right. That's a much nicer solution. > Attached another try. > I left out the check, if the linux.prefered.browser value has ben altered, > as this is effectively more effort than call the setBrowser function > each time > the configuration file is saved, or do I miss some important point here....
I think it's ok. This code is not called that often. > In webBrowser.cpp I created a private function windows_open_url > and placed the windows related code there, so the actuall openUrl only > checks the os and wich function to call... (seemes more logical to me, > because the mac and linux calls are in functions-the windows weren't) Agreed (even if it would have been better to fix this in a separate patch, but I am a nitpicker). > the diff's in the attachment are against the actual revision of the > wengophone-2.2 branch, > because in the trunk, the location of the WebBrowser.cpp and .h moved to > libs/owutils/system...(the trunk have compilations errors on my system > so I used the 2.2 branch...) That's not a problem, we'll take care of this. A few comments though: I changed the static 'defaultBrowser' in WebBrowser.cpp from a char* to a std::string. It's not good to keep a reference to the result of std::string::c_str(), since it won't be valid anymore when the std::string is deleted. It's easier for us if you only send one diff file containing all changes. The simplest way to do so is to run "svn diff" from the root of the project. Note that you will need to generate separate diffs when your changes affect code in svn:externals. In your case you would run one "svn diff" from the root of the project and one other from the "libs/owutil" dir. I committed your patch in r12641 (owutil) and r12642 (wengophone). Aurélien _______________________________________________ Wengophone-devel mailing list [email protected] http://dev.openwengo.com/mailman/listinfo/wengophone-devel
