Darshaka Pathirana wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi!

On 27.02.2008 10:41, Darshaka Pathirana wrote:
# HG changeset patch
# User Darshaka Pathirana <[EMAIL PROTECTED]>
# Date 1204105234 -3600
# Node ID 1e5faf24ff744bb5b6626b85f1812eea8a434f30
# Parent  1ad84979d9aa578ded07ebfc953b549271f23278
imported patch wifi_phapi_WENGOPHONE_UA.patch

On 27.01.2008 13:35, Andreas Schneider wrote:
Darshaka Pathirana wrote:
2. The Visual C++ compiler option "-D" do strip the quotes on the
command line[2] so this must be handled by a define in "phapi.c".
That's bad, have you tried to escape them? There should be another
way to do that.

-
-DWENGOPHONE_UA="\"wengo/v1/wengophoneng/wengo/rev${SVN_REVISION}/trunk/\""
or


-
-DWENGOPHONE_UA='"wengo/v1/wengophoneng/wengo/rev${SVN_REVISION}/trunk/"'
or


-
-DWENGOPHONE_UA="'wengo/v1/wengophoneng/wengo/rev${SVN_REVISION}/trunk/'"
- wifo/phapi/phapi.c

This is the second part of the "-D"-compiler-option problem of
Visual C++. I was not able to get the SVN-Revision into it so
it's set to "0".  If somebody knows how to fix that (and knows
how to include the svn command line in the build process) please
let me / us know. Thanks!

See above

As I still have no good solution on passing the mercurial revision
to the code when building with Visual Studio 2005 it is important to
have a workaround 'cause without the patch the code stays
uncompilable.

My workaround sets the revision to 0 if the compiler is VC++.

A better solution I can think of is to read a external file (like
#include <hg_revision.h>) which is generated by an
cmake-pre-build-process.  Maybe somebody knows how to do that as my
knowledge on CMake is merely humble.

Greetings,
 - Darsha



Actually it works perfectly well the SVN_VERSION variable holds merucrial rev hash now

Thanks
Vadim
_______________________________________________
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel

Reply via email to