Update of patch #921 (project wesnoth):
Status: None => In Progress
Assigned to: None => sapient
_______________________________________________________
Follow-up Comment #3:
1. this line "font::NULL_MARKUP + message" is incorrect because it doesn't
handle multiple lines. Use the new null_markup() method instead.
2. "if(text_input&&options.empty()==false)" this is an unnecessary
restriction, in my opinion. dialogs can support both.
3. you forgot to sanitize input_max_size < 1 ?
4. "if(text_input==true)" -- that's exceedingly redundant don't you think?
just name it more like a boolen, e.g. "if(has_text_input)"
5. "const bool use_menu = ((menu_ != empty_menu)||(text_widget_!=NULL));"
abusing the "use_menu" variable is really the wrong way to go about this;
please insert the appropriate logical checks!
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?921>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
