Follow-up Comment #6, patch #1139 (project wesnoth):
The patch is fine with me (especially as it matches my local implementation
;-) except for all the changes that add an explicit t_str suffix. Please find
a way so that, for instance, the following change is unneeded: type_name_ =
cfg_["name"].t_str().
Also, do you really need the conversion operator to std::string?
Concerning the speed issue, you can change the t_string conversion operator
so that it returns a const reference (temporarily, until you decide other
things than t_string only). I haven't thought much about it, not sure if it
could break something.
Concerning the patch itself, please note that you have used spaces instead of
tabs to indent your changes to config.hpp.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1139>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs
