Follow-up Comment #1, bug #20249 (project wesnoth):
While trying to figure out why CTRL+SPACE wasn't working, I found another
problem which could be causing this. The method get_hotkey() is being used
inconsistently, swapping ctrl and alt in places. Here's a patch showing the
problem.
Index: src/hotkeys.cpp
===================================================================
@@ -752,8 +759,8 @@
return get_hotkey(event.keysym.unicode, event.keysym.sym,
(event.keysym.mod & KMOD_SHIFT) != 0,
(event.keysym.mod & KMOD_CTRL) != 0,
- (event.keysym.mod & KMOD_META) != 0,
- (event.keysym.mod & KMOD_ALT) != 0
+ (event.keysym.mod & KMOD_ALT) != 0,
+ (event.keysym.mod & KMOD_META) != 0
#ifdef __APPLE__
|| (event.keysym.mod & KMOD_RMETA) != 0
#endif
Index: src/hotkey_preferences_display.cpp
===================================================================
--- src/hotkey_preferences_display.cpp (revision 55565)
+++ src/hotkey_preferences_display.cpp (working copy)
@@ -626,8 +626,8 @@
case SDL_KEYUP:
oldhk =
&hotkey::get_hotkey( character,
keycode,
- (mod & KMOD_SHIFT) !=
0, (mod & KMOD_CTRL) != 0,
- (mod & KMOD_LMETA) !=
0, (mod & KMOD_ALT) != 0 );
+ (mod & KMOD_SHIFT) !=
0, (mod & KMOD_CTRL) != 0,
+ (mod & KMOD_ALT) !=
0, (mod & KMOD_LMETA) != 0 );
newhk.set_key(character, keycode, (mod & KMOD_SHIFT)
!= 0,
(mod & KMOD_CTRL) != 0, (mod &
KMOD_ALT) != 0,
(mod & KMOD_LMETA) != 0);
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?20249>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
