[ 
https://issues.apache.org/jira/browse/WHIRR-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002665#comment-13002665
 ] 

David Alves commented on WHIRR-246:
-----------------------------------

Btw I just remembered something that might be relevant.

When updating a cluster we will do so based on the current state, up to now 
using the local filesystem was not a problem because no decisions (that I know 
of) were made based on this file. This will change with WHIRR-214 and so a 
problem might arise where if the cluster is started on one machine and updated 
on another, update decisions might be based on a non-existing or state state.

> Single place to store/load cluster state
> ----------------------------------------
>
>                 Key: WHIRR-246
>                 URL: https://issues.apache.org/jira/browse/WHIRR-246
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: David Alves
>            Priority: Minor
>         Attachments: WHIRR-246.patch
>
>
> Right now cluster state is written and read from the 
> ~/.whirr/cluster-name/instances file and logic to write and update it is 
> spread between the Service and DestroyInstanceCommand (that I know of).
> Since for WHIRR-214 the file must be updated (in another class) and for 
> WHIRR-238 an altogether different method of storing cluster state will be 
> required I think it might be time to move the read/write state logic to its 
> own file (or factory in the future).
> I'll attach a very preliminary patch just to get some feedback.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to