[ 
https://issues.apache.org/jira/browse/WHIRR-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002727#comment-13002727
 ] 

Tom White commented on WHIRR-246:
---------------------------------

What I meant by the Service wrapper was to have an implementation of service 
that takes a Service and persists its cluster state for it. This was just one 
way of implementing it, and I'm not wedded to the idea. Another thing to 
consider is that some users of the API may not need any persistence of state at 
all (e.g. when running a single VM test - like the integration tests), so we 
should make it optional, either by having a no-op ClusterState, or by not using 
a wrapper.

> Single place to store/load cluster state
> ----------------------------------------
>
>                 Key: WHIRR-246
>                 URL: https://issues.apache.org/jira/browse/WHIRR-246
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: David Alves
>            Priority: Minor
>         Attachments: WHIRR-246.patch, WHIRR-246.patch
>
>
> Right now cluster state is written and read from the 
> ~/.whirr/cluster-name/instances file and logic to write and update it is 
> spread between the Service and DestroyInstanceCommand (that I know of).
> Since for WHIRR-214 the file must be updated (in another class) and for 
> WHIRR-238 an altogether different method of storing cluster state will be 
> required I think it might be time to move the read/write state logic to its 
> own file (or factory in the future).
> I'll attach a very preliminary patch just to get some feedback.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to