[
https://issues.apache.org/jira/browse/WHIRR-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026668#comment-13026668
]
Tom White commented on WHIRR-246:
---------------------------------
Looks good. +1
Couple of nits:
* The withIds() method on RolePredicates has a method that takes an @Nullable
argument, but doesn't check the case for it being null.
* MemoryClusterStateStore might be useful in the main tree, e.g. for clients
that use Whirr to run tests from a single JVM. But there's no mechanism to hook
it up yet, so could be left until later.
> Single place to store/load cluster state
> ----------------------------------------
>
> Key: WHIRR-246
> URL: https://issues.apache.org/jira/browse/WHIRR-246
> Project: Whirr
> Issue Type: Improvement
> Reporter: David Alves
> Assignee: Andrei Savu
> Priority: Minor
> Attachments: WHIRR-246.patch, WHIRR-246.patch, WHIRR-246.patch,
> WHIRR-246.patch
>
>
> Right now cluster state is written and read from the
> ~/.whirr/cluster-name/instances file and logic to write and update it is
> spread between the Service and DestroyInstanceCommand (that I know of).
> Since for WHIRR-214 the file must be updated (in another class) and for
> WHIRR-238 an altogether different method of storing cluster state will be
> required I think it might be time to move the read/write state logic to its
> own file (or factory in the future).
> I'll attach a very preliminary patch just to get some feedback.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
