Sure, done. The issue is still open. I'm still not convinced we should ship the reloading filter tbh. As it only works with quite a few ifs and buts, I'd rather see the reloading filter (and class locator) to be part of wicket-extensions or maybe as a WIKI article or such. Though I'm fine with the patches that provide the basis for it to work (like setting the context loader etc)
So far I think only Johan and I have looked at it, but before we decide on whether this should be part of Wicket core/ extensions or not, I think more people should look at it and give their opinions. My concern is not that this isn't useable - in fact I think many people will find it great - but I am afraid that if we officially support it, people *will* expect it to work for all occasions, and when it doesn't they would expect us to provide answers, fixes and so on. Personally, I'm not sure if I'm ready to do that. That said, I think the aim is great, and if there are improvements possible still and/ or other developers think it is a great addition we can certainly keep it in the pipe-line. Eelco On 12/11/06, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote:
Hi, The code to reload classes is already in Wicket branch 1.x, but there's a (hopefully) last fix to apply. Could one of you please have a look at: https://issues.apache.org/jira/secure/attachment/12346428/20061205-wicket-1.x-ReloadingClassLoader * Use ArrayList instead of HashSet for the patterns to keep the order in which they were added * Add methods includePattern() and excludePattern() * Set default patterns in the static block Thanks in advance, -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/
