On 1/9/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
On 1/9/07, Johan Compagner <[EMAIL PROTECTED]> wrote: > exactly > We shouldn't delete any files only when the session is closed. > Why do this when the session is live? To save some space? > That looks to me like a wast of time when the session is still live and > kicking > and request is handled. Because if you rollback from version 10 to version 5 and do component replacements on it, you'll be at version 6 again. And I we shouldn't just write everytime like we did before, as that is *really* inefficient (like writing out the same thing twice a request and when coming back to the same page without a version change, still a write every time).
But if you make a new version number then those will be overwritten yes.. Or we should make it so that if you go back to version 5 and then forward again. The next version should still be 11 (so just like page numbers) never give the same version number twice always increment. Because you can do this: page version 10 is the current back,back,back only refresh forward,forward,forward refresh This is doable in a browser but wicket (1.2.x) doesn't support it you will get a page expired. I agree that writes shouldn't happen to much. So when we make a Global version manager That only saves a new version (the changeset) when it gets actually a new version with changes. and the SecondLevelSessionStore only saves a page when it falls out of the pagemap (so another page will be the current one) Then saves are a lot less johan
