its in trunk, who cares how much trivial api you break...if this saves a creation of a string (charseq->string->charseq) then keep the change
-igor On 2/10/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: ehillenius Date: Sat Feb 10 21:53:52 2007 New Revision: 505851 URL: http://svn.apache.org/viewvc?view=rev&rev=505851 Log: rolled back charsequence change. doesn't matter enough to break more api Modified: incubator/wicket/trunk/wicket/src/main/java/wicket/util/string/Strings.java Modified: incubator/wicket/trunk/wicket/src/main/java/wicket/util/string/Strings.java URL: http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/util/string/Strings.java?view=diff&rev=505851&r1=505850&r2=505851 ============================================================================== --- incubator/wicket/trunk/wicket/src/main/java/wicket/util/string/Strings.java (original) +++ incubator/wicket/trunk/wicket/src/main/java/wicket/util/string/Strings.java Sat Feb 10 21:53:52 2007 @@ -247,7 +247,7 @@ * @see Strings#escapeMarkup(String, boolean) * @return The escaped string */ - public static CharSequence escapeMarkup(final CharSequence s) + public static CharSequence escapeMarkup(final String s) { return escapeMarkup(s, false); } @@ -265,7 +265,7 @@ * True to replace ' ' with nonbreaking space * @return The escaped string */ - public static CharSequence escapeMarkup(final CharSequence s, final boolean escapeSpaces) + public static CharSequence escapeMarkup(final String s, final boolean escapeSpaces) { return escapeMarkup(s, escapeSpaces, false); } @@ -285,7 +285,7 @@ * True to convert non-7 bit characters to unicode HTML (&#...) * @return The escaped string */ - public static CharSequence escapeMarkup(final CharSequence s, final boolean escapeSpaces, + public static CharSequence escapeMarkup(final String s, final boolean escapeSpaces, final boolean convertToHtmlUnicodeEscapes) { if (s == null) @@ -550,7 +550,7 @@ * @param string2 * @return true, if both strings are equal */ - public static boolean isEqual(final CharSequence string1, final CharSequence string2) + public static boolean isEqual(final String string1, final String string2) { if ((string1 == null) && (string2 == null)) {
