IMO I think we should get this release to IPMC, not worrying about
functional issues. I know it takes Martijn quite a while to do a release
(Wicket *is* a big project with many subprojects so it will take some time
to release) and this release here is only for IPMC.
Comments below
On 3/26/07, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote:
I noticed a few things.
README.txt
Shall we replace wicket-library.com with wicketstuff.org?
Fair enough. jpq would you say this is a showstopper or can we put in on the
todo for next release. I don't think it's something that will give us
problems with IPMC.
NOTICE.txt
Every NOTICE.txt file has duplicates:
jdk-1.4/wicket/NOTICE.txt
jdk-1.4/wicket/target/classes/META-INF/NOTICE.txt
jdk-1.4/wicket-datetime/NOTICE.txt
jdk-1.4/wicket-datetime/target/classes/META-INF/NOTICE.txt
Thats on purpose. The one in META-INF is included in the jar file as
required. It is also first generated when building the jar file.
NOTICE.txt again
Mention that CreditCardValidator, WildcardMatcherHelper comes from
Apache Cocoon maybe.
Ok. Can you add it to the appropriate notice file?
FILES
There's a spurious "target" directory in "src".
See previous discussions. Martijn has some problems getting rid of it. I
think we should say that this release is for IPMC and may still not be
perfect. Just as long as it doesn't contain something that give us legal
problems.
EXAMPLES
I can't run the examples as a WAR with Jetty 6.1.1 default
configuration:
java.lang.LinkageError: Class javax/management/MBeanServer violates loader
constraints
at java.lang.ClassLoader.defineClass1 (Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:620)
at java.security.SecureClassLoader.defineClass(
SecureClassLoader.java:124)
at java.net.URLClassLoader.defineClass (URLClassLoader.java:260)
at java.net.URLClassLoader.access$100(URLClassLoader.java:56)
at java.net.URLClassLoader$1.run(URLClassLoader.java:195)
at java.security.AccessController.doPrivileged (Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
at org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(
WebAppClassLoader.java:354)
at org.mortbay.jetty.webapp.WebAppClassLoader.loadClass (
WebAppClassLoader.java:325)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
at wicket.jmx.Initializer.init(Initializer.java:152)
at wicket.Application.callInitializers(Application.java :781)
at wicket.Application.initializeComponents(Application.java:665)
at wicket.protocol.http.WicketFilter.init(WicketFilter.java:398)
...
If I unpack the war and remove
wicket-examples/WEB-INF/lib/mx4j- 3.0.1.jar the application
launches alright.
EXAMPLES again
I click on Ajax > Clock Examples
Then I click on [go back] while opening a new browser tab (with
middle mouse button). The ajax clock page shows "Page Expired" at
next refresh.
All of these are functional problems, which IMHO not showstoppers for this
release how buggy they might be.
I stop investigating now, enough things to care for already.
I think we would appreciate if you could investigate thoroughly now so
Martijn don't have to build this release too many times.
Unless there is something wrong on my side, I vote -1 so that we
can fix this blocker JMX loading problem at least.
IMHO I wouldn't vote -1 on any functional problems, only legal ones. You
have found attribution which we haven't mentioned in the correct NOTICE file
and that would make me say -0.9 to this release.
Frank
