On 5/5/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
You're right about that. EmptyPanel is better, and it should probably be final.
Yes, I think EmptyPanel has the merit of being more obvious in its intent, and less error prone.
Xavier
Eelco On 5/5/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > will that really make things better? if you misname the markup file you will > now get component not found rather then markup not found. > > -igor > > > On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > > > > How about giving Panel.java an accompanying Panel.html file? That > > would obviate the need of adding EmptyPanel, and anyone subclassing > > Panel would override it by supplying their own markup. > > > > Martijn > > > > On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > > > +1, another class I can remove from our project :) > > > > > > On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > > so i propose a vote to add this. i'm +1. > > > > > > > > > > > > Eelco Hillenius wrote: > > > > > > > > > > Yeah. I actually think I proposed something like this, or at least > > > > > +1-ed one at more than a year ago. You'll have to dig in the > > archives > > > > > to find out why other people didn't agree back then, but I still > > think > > > > > it's much easier for users to discover something just because it has > > > > > an obvious name, and not to worry about that one extra class. > > > > > > > > > > Eelco > > > > > > > > > > > > > > > On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > > >> > > > > >> In my work project, I've added and frequently use an EmptyPanel > > which is > > > > >> simply a panel with empty markup. Although you can do the same > > thing > > > > >> with > > > > >> WebMarkupContainer or implement this yourself, it does seem like a > > nice > > > > >> conceptual addition, particularly for newbies who might not think > > "hmm... > > > > >> i > > > > >> want an empty panel instead of this fancy panel if the user isn't > > logged > > > > >> in... oh WebMarkupContainer looks about right..." ;-) Anyway, I > > thought > > > > >> I'd > > > > >> mention it in case others feel this would be a nice addition to > > core. > > > > >> -- > > > > >> View this message in context: > > > > >> http://www.nabble.com/EmptyPanel--tf3692546.html#a10324363 > > > > >> Sent from the Wicket - Dev mailing list archive at Nabble.com. > > > > >> > > > > >> > > > > > > > > > > > > > > > > > > -- > > > > View this message in context: > > http://www.nabble.com/EmptyPanel--tf3692546.html#a10333463 > > > > Sent from the Wicket - Dev mailing list archive at Nabble.com. > > > > > > > > > > > > > > > > > -- > > > Learn Wicket at ApacheCon Europe: http://apachecon.com > > > Join the wicket community at irc.freenode.net: ##wicket > > > Wicket 1.2.6 contains a very important fix. Download Wicket now! > > > http://wicketframework.org > > > > > > > > > -- > > Learn Wicket at ApacheCon Europe: http://apachecon.com > > Join the wicket community at irc.freenode.net: ##wicket > > Wicket 1.2.6 contains a very important fix. Download Wicket now! > > http://wicketframework.org > > >
-- Xavier Hanin - Independent Java Consultant Manage your dependencies with Ivy! http://incubator.apache.org/ivy/
