still again. what do we mess up i haven't seen an example yet i am very curious about that because we do print once the Complete stacktrace and that is of the root cause The only thing we do different then then java itself is that we dont do
top exception xxxx top-1 exception xxx 10 more.. top-2 exception xxxx 20 more.. root cause xxxx 30 more.. no we do only the complete root cause immediantly as the top one. Because that is what you want to see. On 6/21/07, Jonathan Locke <[EMAIL PROTECTED]> wrote:
i just want to change the code so that Strings.toString(throwable) does not do this. we can move this stack trace trimming code into the exception page. that way we're 100% sure that it will never mess up. i think at least one of the truncated stack traces i've found was caused by multithreading in the log files, but i still feel very uneasy about anything that processes stack trace strings. i think only the exception page display code should do that if anything. maybe the exception display page should just hide all the extra details using a javascript triggered fold-out instead of trying to programmatically remove it? i would feel better if we simply weren't doing this trimming at all. Johan Compagner wrote: > > i still don't get it what then should be changed > We are printing the complete stack.. > the root cause is completely printed. Only the exceptions around the root > cause is not completely printed. (those are stopped at the wicket > servlet/filter) > > johan > > > On 6/20/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: >> >> >> >> do i need a vote to make this change at this point? >> >> >> Eelco Hillenius wrote: >> > >> >> It might be good to be more defensive here then (as I think the trace >> I >> >> got >> >> had lost the info in both places): We could turn >> >> Strings.toString(Throwable) >> >> back into a simple version that always gives you the entire stack >> trace >> >> (I >> >> would really prefer that since this is supposed to be a generic >> utility). >> >> Then take the fancy version that's in the util package now and make a >> >> private implementation detail of the exception page(s). That way >> nobody >> >> can >> >> accidentally make the mistake of removing exception information from a >> >> log >> >> or the console. >> > >> > I agree. >> > >> > Eelco >> > >> > >> >> -- >> View this message in context: >> http://www.nabble.com/abbreviated-stack-traces-tf3837742.html#a11219888 >> Sent from the Wicket - Dev mailing list archive at Nabble.com. >> >> > > -- View this message in context: http://www.nabble.com/abbreviated-stack-traces-tf3837742.html#a11224009 Sent from the Wicket - Dev mailing list archive at Nabble.com.
