AjaxSubmitButton is a right name because its only purpose is that it
submits a form right?
But i don't mind that it is renamed
but Button is not only a SubmitButton. We could make a subclass that really
makes a input type=submit?
(or test fors it)
Because i use buttons on many places to replace links (but the look and feel
of a button)
so for me its not what they do, its how the look.
So now AjaxButton always submits and Button can submit but also used as a
link click..
So maybe a bit better thing would be to hava a AjaxSubmitButton and a
SubmitButton (extends Button)
and let button be used also for the other types or maybe introduce
LinkButton?
johan
On 6/21/07, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote:
+0
The Javadoc says: "A button that submits the form via ajax". And
the callback method is called onSubmit().
So even if you rename the class (which is a very costly operation
in a framework), it won't be sufficient to eradicate the term
"submit".
I understand that you want to streamline the name with Button, but
actually I would vote to rename Button to SubmitButton. I was
recently doing pair programming with a colleague, and we were
stupidly looking for "SubmitButton" and wondered why it was not
showing up. It was the obvious class name we thought...
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
