On 7/1/07, Gerolf Seitz <[EMAIL PROTECTED]> wrote:

i found some naming inconsistencies:
JavaScriptReference vs. JavascriptResourceReference
there are some other Java(S/s)cript classes...

Johan Compagner wrote:
please send in a patch so that we can have the right names before the
final of 1.3

Changing the case of Java files tends to cause pain on Windows systems, because they're case-insensitive. We're almost guaranteed to have people with strange ClassNotFoundExceptions if we go and do this.

It's yet another API change just before we release 1.3.0.

If we fix the class names, we should also fix the method names. There's a lot of inconsistency at the moment, and this would cause an awful lot of API breakage.

It would make sense to use "Javascript" everywhere, as "JavaScript" is one word, so when you CamelCase it, it should all go lower.

Otherwise, if you have a "JavaScriptHandler", is it a ScriptHandler for Java, or a Handler for JavaScript?

Anyway, there's a bunch of stuff we'd need to fix, including HeaderContributor.forJavaScript(), etc. etc.

I don't think we want to do that this close to a 1.3 release. I imagine it'd be a faff for the upcoming Wicket book, too.

Best regards,

Al
--
Alastair Maw
Wicket-biased blog at http://herebebeasties.com

Reply via email to