However this second api change (returning the actual page) breaks a lot
in the contrib-dataview. Should we still proceed with that change as well?
Currently I'm -1 on that one. The API is not wrong, it is mere
convenience, and not a good one at that, considering the things I saw in
contrib-dataview.
Martijn
On 9/21/05, *Johan Compagner* <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>> wrote:
yes that change is also fine by me the change is minimal to the api
On 9/21/05, *Igor Vaynberg* < [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>> wrote:
I guess if you want to throw that in…
Have setCurrentPage() return the actual page number that was
set. This saves an extra call to getCurrentPage()…
-Igor
------------------------------------------------------------------------
*From:* [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>
[mailto:[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>] * On Behalf
Of *Johan Compagner
*Sent:* Wednesday, September 21, 2005 12:38 AM
*To:* [email protected]
<mailto:[email protected]>
*Subject:* Re: [Wicket-develop] VOTE: apply patch 1288863 -
forgotten refactorings in PagingNavigator
+1
and didn't igor and others also want one other change (i think
it was an int returned when setCurrentPage() or something was
called)
this is also something that is ok for me to do.
On 9/21/05, *Eelco Hillenius* <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>> wrote:
+1
Eelco
On 9/21/05, Phil Kulak <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>> wrote:
+1
On 9/20/05, Nick Heudecker <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>> wrote:
> Everybody's a critic. :)
>
>
> On 9/20/05, Martijn Dashorst <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>> wrote:
> > The api was newly introduced in Wicket 1.1 (it is a
refactor from 1.0). So
> deprecating /new/ api, seems not the way to go ;-)
> >
> > Martijn
> >
> >
> >
> >
> > On 9/21/05, Nick Heudecker < [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]> > wrote:
> > > I'm +1 on deprecating the old method name for a bit and
adding the new
> one. However, I also understand if you guys don't want to
get into
> deprecation hell.
> > >
> > >
> > >
> > > On 9/20/05, Martijn Dashorst <
[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>
wrote:
> > > > All,
> > > >
> > > > Igor submitted a patch in PagingNavigator, which
contains an API
> change: rename pageableListViewNavigation to pagingNavigation.
> > > >
> > > > This also means changing the getter for this field in the
> PagingNavigator.
> > > >
> > > > Since we're in the RC cycle, we'll have to be /a lot/
more formal on
> changing API's, so I opened this one. The vote will close in
24 hours.
> > > >
> > > > I'm +1 on changing this.
> > > >
> > > > Martijn
> > > >
> > > >
> > >
> > >
> >
> >
>
>
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App
Server. Download
it for free - -and be entered to win a 42" plasma tv or your
very own
Sony(tm)PSP. Click here to play:
http://sourceforge.net/geronimo.php
_______________________________________________
Wicket-develop mailing list
[email protected]
<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App
Server. Download
it for free - -and be entered to win a 42" plasma tv or your
very own
Sony(tm)PSP. Click here to play:
http://sourceforge.net/geronimo.php
_______________________________________________
Wicket-develop mailing list
[email protected]
<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/wicket-develop
