> -----Original Message-----
> From: [EMAIL PROTECTED] 
> [mailto:[EMAIL PROTECTED] On Behalf Of 
> Christian Essl
> Sent: Wednesday, August 10, 2005 2:06 PM
> To: [email protected]
> Subject: Re: [Wicket-user] DataView: IDataProvider.primaryKey() vote
> 
> I don't want to start a flame war here too. So my vote is 0.
> 
> My suggestion is not based on IModel identity but equality. 
> If users do not implement equals/hashCode on the IModel 
> gotten from model(Object) than all old DataItems will be 
> removed and newly recreated. DataView will still work (less 
> efficient of course). If they implement equals/hasCode
> (correctly) the DataItems with equal IModels will be kept.

The con is that here the understanding of what needs to go into equals and
hashcode is unclear. Also the Imodel is more of a locator rather then the
model itself, it doesn't really make sense to have equals and hashcode for
locators.

> The right implementation of equals/hashCode is as much out of 
> the control of the framework as the right implementation of 
> primaryKey().

Yes you are right, but it's a lot clearer what the function of the
primarykey() is.

> Sorry if I have bothered you. I think currently the vote is 
> clear and we should stop this.

You havent bothered me. The vote is so that we can decide whether or not we
should spend more time to figure out how to do this rather then dropping the
idea entirely.

-Igor




-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user

Reply via email to