Alrite, without spending too much more time on this, entartain this idea:
Move primarykey to IPrimaryKeyProvider { String primaryKey() }The dataview can do an instanceof check on the impl of IDataProvider, if it implements iprimarykeyprovider use that otherwise use a generic counter. -Igor > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Christian Essl > Sent: Wednesday, August 10, 2005 2:06 PM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] DataView: IDataProvider.primaryKey() vote > > I don't want to start a flame war here too. So my vote is 0. > > My suggestion is not based on IModel identity but equality. > If users do not implement equals/hashCode on the IModel > gotten from model(Object) than all old DataItems will be > removed and newly recreated. DataView will still work (less > efficient of course). If they implement equals/hasCode > (correctly) the DataItems with equal IModels will be kept. > > The right implementation of equals/hashCode is as much out of > the control of the framework as the right implementation of > primaryKey(). > > Sorry if I have bothered you. I think currently the vote is > clear and we should stop this. > > Christian > > On Wed, 10 Aug 2005 21:51:45 +0200, Johan Compagner > <[EMAIL PROTECTED]> > wrote: > > > how would it work then? > > How do we guarantee that they implement it right? > > > > Igor Vaynberg wrote: > >> This is a vote to remove primaryKey() from IDataProvider and use > >> Imodel instance identity in order to provide optimized > item removal > >> in the dataview. > >> > >> > >> > >> > >> ------------------------------------------------------- > >> SF.Net email is Sponsored by the Better Software Conference & EXPO > >> September 19-22, 2005 * San Francisco, CA * Development Lifecycle > >> Practices Agile & Plan-Driven Development * Managing > Projects & Teams > >> * Testing & QA Security * Process Improvement & Measurement * > >> http://www.sqe.com/bsce5sf > >> _______________________________________________ > >> Wicket-user mailing list > >> Wicket-user@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/wicket-user > >> > >> > > > > > > ------------------------------------------------------- > > SF.Net email is Sponsored by the Better Software Conference & EXPO > > September 19-22, 2005 * San Francisco, CA * Development Lifecycle > > Practices Agile & Plan-Driven Development * Managing > Projects & Teams > > * Testing & QA Security * Process Improvement & Measurement * > > http://www.sqe.com/bsce5sf > > _______________________________________________ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > -- > Christian Essl > > > > > > ___________________________________________________________ > Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - > Hier anmelden: http://mail.yahoo.de > > > > ------------------------------------------------------- > SF.Net email is Sponsored by the Better Software Conference & EXPO > September 19-22, 2005 * San Francisco, CA * Development > Lifecycle Practices > Agile & Plan-Driven Development * Managing Projects & Teams * > Testing & QA > Security * Process Improvement & Measurement * > http://www.sqe.com/bsce5sf > _______________________________________________ > Wicket-user mailing list > Wicket-user@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
