Read below...Igor Vaynberg wrote:
Gili, All you would be doing is factoring out semantic incompatibilities into the strategy interface/impls. In a way the old pageabledataview was a navigation strategy for the regular dataview. Please try to understand the problem. Let me lay it out for you: The dataview class has setFirstIndex() and setViewSize() methods. The pagabledataview extends the dataview and so inherits those, alongside introducing the setCurrentPage()/setRowsPerPage(). The problem is that setFirstIndex() and setViewSize() do not make sense in the pageable subclass. What does setViewSize(5) mean when you already called setRowsPerPage(10)??? What does setFirstIndex(10) mean when you called setCurrentPage(5)?
You might consider having an abstract base class with neither setFirstIndex(), setViewSize() or the page-oriented methods. Then have one subclass for linear navigation and another one for page-oriented navigation. If setFirstIndex() does not make sense for all subclasses then it likely does not belong in the subclass.
Gili ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
