I removed the setStartIndex() and setViewSize() from dataview and setcurrentpage() simply ignores the page if paging is disabled instead of throwing illegalstateexception. I also introduced the populateitems(int first, int count), Chris let me know if that's what you wanted.
I noticed there is a problem with the back button support in the paging example. If you go to page 2 and then use the back button to go to page1 and click a link, you get an error. Any ideas why this is happening? I thought the versioning support would role back the dataview dataitems to the state they were... -Igor > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Christian Essl > Sent: Wednesday, August 31, 2005 9:58 PM > To: [email protected] > Subject: Re: [Wicket-user] PageableGridDataView > > Hi Igor, > > Thanks for the compliments. I am happy you like it. > > > I was also thinking of getting rid of pageable dataview and > > introducing enablePaging(int rowsperpage)/disablePaging() into > > dataview directly. What do you think? > > > > +1 > > That's a very good idea. I also do not like PageableDataView > with the unsupported methods. I was just concerned about > memory. Lazy-creation of a PageableSupport solves that. I > think you mean when not enabled > getPageCount() either returns 1 or 0, getCurrentPage() > returns pageCount-1 and setCurrentPage() does nothing. Cool > idea, would be completly transparent and (nearly) no > additional memory. > > Maybe you could than also add a protected method > populateItems(int start, int count) which does the DataItem > population and gets called from internalOnBeginRequest(). So > GridDataView could (esaly) extend the new DataView. > > Christian > > > > > > ___________________________________________________________ > Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - > Hier anmelden: http://mail.yahoo.de > > > > ------------------------------------------------------- > SF.Net email is Sponsored by the Better Software Conference & EXPO > September 19-22, 2005 * San Francisco, CA * Development > Lifecycle Practices > Agile & Plan-Driven Development * Managing Projects & Teams * > Testing & QA > Security * Process Improvement & Measurement * > http://www.sqe.com/bsce5sf > _______________________________________________ > Wicket-user mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Wicket-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-user
