nice thing about having an interface is that you dont have to do that, you can aggregate on demand and for things like Iterator simply return a compound iterator. but this is more work.

i guess your way works too. create a patch and attach it to our sf.net tracker and one of the core devels will merge it in.

-Igor


On 5/9/06, Ittay Dror < [EMAIL PROTECTED]> wrote:


Igor Vaynberg wrote:
> hrm, so now if you want to join the two what do you do in getMessages()
> of the compound impl?
>
> create a new arraylist and merge messages from the other two? do you do
> the merged array generation on every call or keep it in a transient field?

i copy the code from FeeedbackMessagesModel ;-) (it keeps the array in a transient field)

>
> -Igor
>
>
> On 5/9/06, *Ittay Dror* <[EMAIL PROTECTED]
> <mailto:[EMAIL PROTECTED]>> wrote:
>
>     ok, i have it. how do i send it?
>
>     i created an AbstractFeedbackMessages, which has 2 abstract methods:
>     isReadonly() and getMessages(). the rest use them
>
>     i'm thinking of maybe change it to ReadonlyFeedbackMessages and
>     FeedbackMessages which will extend it, and CompoundFeedbackMessages
>     will extend it also.
>
>     what do you think?
>
>     Igor Vaynberg wrote:
>      > maybe you can submit a patch
>      >
>      > here is what i would suggest
>      >
>      > extract IFeedbackMessages interface from FeedbackMessages and
>     create a
>      > CompoundFeedbackMessages impl, that way you can join the session and
>      > page messages yourself and still use the same utility methods in
>      > FeedbackMessages on the joined collection.
>      >
>      > how does that sound?
>      >
>      > -Igor
>      >
>      >
>      > On 5/9/06, *Ittay Dror* <[EMAIL PROTECTED]
>     <mailto: [EMAIL PROTECTED]>
>      > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>> wrote:
>      >
>      >
>      >
>      >     Igor Vaynberg wrote:
>      >      > so you want to use it outside the model?
>      >
>      >     outside of an IModel context, yes.
>      >
>      >      >
>      >      > but then feedbackpanel.anyMessage(int level) is just
>      >      >
>      >      > Page.getFeedbackMessages ().hasAnyMessage(new
>      >      > ErrorLevelFeedbackMessage(level)) no?
>      >
>      >     no, because the model joins the page messages and session
>     messages
>      >
>      >      >
>      >      > -Igor
>      >      >
>      >      >
>      >      > On 5/9/06, *Ittay Dror* < [EMAIL PROTECTED]
>     <mailto: [EMAIL PROTECTED]>
>      >     <mailto: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED] >>
>      >      > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
>     <mailto: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>> wrote:
>      >      >
>      >      >     it will be too much of a pain, since most issues are
>     because i'm
>      >      >     using wicket in an existing application, built on struts.
>      >      >
>      >      >     however, i would appriciate it if you could answer
>     some specific
>      >      >     questions.
>      >      >
>      >      >     i'm trying to create my own feedback panel. an issue i
>      >     encountered
>      >      >     is that FeedbackPanel has the anyMessages() method,
>     which i also
>      >      >     need, i can copy the code, but isn't it better to move
>     it to
>      >      >     FeedbackMessage, as static utility methods? or, better
>     yet,
>      >     create a
>      >      >     FeedbackMessages class which has the logic found in
>      >      >     FeedbackMessagesModel, so it can be reused outside of the
>      >     context of
>      >      >     a model?
>      >      >
>      >      >     ittay
>      >      >
>      >      >     Igor Vaynberg wrote:
>      >      >      > give us an html snippet of what you want as the end
>     result
>      >     and
>      >      >     tell us
>      >      >      > where the components are. it is very difficult to
>     talk on
>      >     such a huge
>      >      >      > abstraction level.
>      >      >      >
>      >      >      > -Igor
>      >      >      >
>      >      >      >
>      >      >      > On 5/9/06, *Ittay Dror* < [EMAIL PROTECTED]
>     <mailto: [EMAIL PROTECTED]>
>      >     <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>
>      >      >     <mailto: [EMAIL PROTECTED]
>     <mailto:[EMAIL PROTECTED]> <mailto:[EMAIL PROTECTED]
>     <mailto:[EMAIL PROTECTED]>>>
>      >      >      > <mailto: [EMAIL PROTECTED]
>     <mailto: [EMAIL PROTECTED]> <mailto: [EMAIL PROTECTED]
>     <mailto:[EMAIL PROTECTED] >>
>      >     <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
>     <mailto: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>>> wrote:
>      >      >      >
>      >      >      >
>      >      >      >
>      >      >      >     Igor Vaynberg wrote:
>      >      >      >      > but what is really a problem then i dont
>      >     understand? all
>      >      >     you want
>      >      >      >     to do
>      >      >      >      > is write out some _javascript_ based on feedback
>      >     messages?
>      >      >     instead of
>      >      >      >      > using a feedbackpanel add a label that
>     writes out the
>      >      >     _javascript_ you
>      >      >      >      > want. you can get the messages using
>      >      >     Page.getFeedbackMessages ()
>      >      >      >      >
>      >      >      >      > so something like this:
>      >      >      >      >
>      >      >      >      >
>      >      >      >      > add(new Label("js", new
>     AbstractReadOnlyModel() {
>      >      >      >      >     Object getObject(Component c) {
>      >      >      >      >           FeedbackMessages msgs=c.getPage
>      >      >     ().getFeedbackMessages();
>      >      >      >      >           AppendingStringBuffer js=new
>      >      >     AppendingStringBuffer();
>      >      >      >      >           //// fill in _javascript_ into js
>      >      >      >      >           return js.toString ();
>      >      >      >      >      }).setEscapeModelStrings(false));
>      >      >      >      >
>      >      >      >      > and you should be good to go right?
>      >      >      >
>      >      >      >     the _javascript_ has a lot of GUI code in it, so it
>      >     looks to me
>      >      >     like
>      >      >      >     something from the early days of servlets. i'm not
>      >     looking for
>      >      >      >     something that works, but, for something that
>     works "the
>      >      >     wicket way"
>      >      >      >
>      >      >      >
>      >      >
>      >      >
>      >      >     --
>      >      >     ===================================
>      >      >     Ittay Dror
>      >      >     Chief architect, openQRM TL,
>      >      >     R&D, Qlusters Inc.
>      >      >     [EMAIL PROTECTED] <mailto: [EMAIL PROTECTED]>
>     <mailto: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED] >> <mailto:
>      >     [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
>     <mailto: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>
>      >      >     +972-3-6081994 Fax: +972-3-6081841
>      >      >
>      >      >     http://www.openQRM.org
>      >      >     - Keeps your Data-Center Up and Running
>      >      >
>      >      >
>      >      >     -------------------------------------------------------
>      >      >     Using Tomcat but need to do more? Need to support web
>     services,
>      >      >     security?
>      >      >     Get stuff done quickly with pre-integrated technology
>     to make
>      >     your
>      >      >     job easier
>      >      >     Download IBM WebSphere Application Server v.1.0.1
>     based on Apache
>      >      >     Geronimo
>      >      >
>      >
>     http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>     <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>
>      >
>     <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>     < http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>>
>      >      >
>      >
>     < http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>     <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >
>      >
>     <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>     <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>>>
>      >      >     _______________________________________________
>      >      >     Wicket-user mailing list
>      >      >     Wicket-user@lists.sourceforge.net
>     <mailto: Wicket-user@lists.sourceforge.net>
>      >     <mailto: Wicket-user@lists.sourceforge.net
>     <mailto: Wicket-user@lists.sourceforge.net>>
>      >      >     <mailto: Wicket-user@lists.sourceforge.net
>     <mailto: Wicket-user@lists.sourceforge.net>
>      >     <mailto: Wicket-user@lists.sourceforge.net
>     <mailto: Wicket-user@lists.sourceforge.net>>>
>      >      >     https://lists.sourceforge.net/lists/listinfo/wicket-user
>      >     < https://lists.sourceforge.net/lists/listinfo/wicket-user>
>      >      >
>      >      >
>      >
>      >
>      >     --
>      >     ===================================
>      >     Ittay Dror
>      >     Chief architect, openQRM TL,
>      >     R&D, Qlusters Inc.
>      >     [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
>     <mailto:[EMAIL PROTECTED] <mailto: [EMAIL PROTECTED]>>
>      >     +972-3-6081994 Fax: +972-3-6081841
>      >
>      >     http://www.openQRM.org
>      >     - Keeps your Data-Center Up and Running
>      >
>      >
>      >     -------------------------------------------------------
>      >     Using Tomcat but need to do more? Need to support web services,
>      >     security?
>      >     Get stuff done quickly with pre-integrated technology to make
>     your
>      >     job easier
>      >     Download IBM WebSphere Application Server v.1.0.1 based on Apache
>      >     Geronimo
>      >
>     http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>     <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>
>      >     <
>     http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>     < http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642>>
>      >     _______________________________________________
>      >     Wicket-user mailing list
>      >     Wicket-user@lists.sourceforge.net
>     <mailto:Wicket-user@lists.sourceforge.net>
>      >     <mailto: Wicket-user@lists.sourceforge.net
>     <mailto:Wicket-user@lists.sourceforge.net>>
>      >     https://lists.sourceforge.net/lists/listinfo/wicket-user
>      >
>      >
>
>
>     --
>     ===================================
>     Ittay Dror
>     Chief architect, openQRM TL,
>     R&D, Qlusters Inc.
>     [EMAIL PROTECTED] <mailto: [EMAIL PROTECTED]>
>     +972-3-6081994 Fax: +972-3-6081841
>
>     http://www.openQRM.org
>     - Keeps your Data-Center Up and Running
>
>
>     -------------------------------------------------------
>     Using Tomcat but need to do more? Need to support web services,
>     security?
>     Get stuff done quickly with pre-integrated technology to make your
>     job easier
>     Download IBM WebSphere Application Server v.1.0.1 based on Apache
>     Geronimo
>     http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>     <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >
>     _______________________________________________
>     Wicket-user mailing list
>     Wicket-user@lists.sourceforge.net
>     <mailto: Wicket-user@lists.sourceforge.net>
>     https://lists.sourceforge.net/lists/listinfo/wicket-user
>     <https://lists.sourceforge.net/lists/listinfo/wicket-user>
>
>


--
===================================
Ittay Dror
Chief architect, openQRM TL,
R&D, Qlusters Inc.
[EMAIL PROTECTED]
+972-3-6081994 Fax: +972-3-6081841

http://www.openQRM.org
- Keeps your Data-Center Up and Running


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Reply via email to