On 6/24/07, Jan Kriesten <[EMAIL PROTECTED]> wrote: > > hi juergen, > > > yes, this a valid comment. The <html> component is causing the > > problem. The header contribution code has obviously been designed in a > > way that it expects to be the very first contribution to the pages > > output markup. With the html component it no longer is, since the > > <html> tag must be rendered first and than, sometimes later, the > > <head> section. > > i understand. so, wouldn't it be the easiest way to change the behavior of the > HeaderContributors to automatically do a > > getBodyContainer().add( new HeaderContributor.forCSS() )?
this would be a possible solution for adding header contributions to WebPages only. But I'm not in favor of such "magic". The exceptions to a rule you have the more difficult it gets to understand a product and even worse, the more effort you have to spend to explain it and to maintain the code. > > this could be tricky since the HeaderContributors are static as far as i've > seen. > > > Though the most obvious approach doesn't right now, it is not a show > > stopper for you, since you can add the HeaderContributor to any other > > component of your page (except the page) and it'll work, correct? > > not quite, my main problem isn't right now that my css don't get added to the > header, but the css for wicket-components like > org.apache.wicket.markup.html.tree.LinkTree > I've reverted the change to WebPage, so it should work. And I think a found the reason why HtmlHeaderContainer didn't work as expected. I changed that too, all junit tests are still fine. I'll committ it in a minute. Juergen > best regards, --- jan. > > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Wicket-user mailing list > Wicket-user@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-user > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
