Review: Needs Fixing
1. see inline comment
2. I did a spotcheck of the helptexts and found multiple issues with the # sign
in TRANSLATORS remarks not correctly implemented. Just checked a couple of
frisian buildings where the ' is used in defined performance helptexts and not
used in other buildings where undefined messages are in place. Found issues in
the barbarians helptexts as well
Diff comments:
>
> === modified file 'data/tribes/wares/shovel/helptexts.lua'
> --- data/tribes/wares/shovel/helptexts.lua 2017-07-07 16:51:39 +0000
> +++ data/tribes/wares/shovel/helptexts.lua 2018-05-03 05:43:13 +0000
> @@ -9,7 +9,7 @@
> -- TRANSLATORS: Helptext for a ware: Shovel
> empire = pgettext("empire_ware", "Therefore the forester and the vine
> farmer use them. They are produced by the toolsmith."),
> -- TRANSLATORS: Helptext for a ware: Shovel
> - frisians = pgettext("frisians_ware", "They are used by berry and reed
> farmers as well as foresters. Diggers also need them to dig mud out of hard
> soil.")
> + frisians = pgettext("frisians_ware", "They are used by berry and reed
> farmers as well as foresters. Brickmakers also need them to dig mud out of
> hard soil.")
> }
They should be replaced with shovel to be consistent with other helptexts
> local result = ""
> if tribe then
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/345000
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
