Admitted, you fix is more elegant.
One nit inline.
Wil still compile and test this
Diff comments:
>
> === modified file 'src/network/network.h'
> --- src/network/network.h 2019-02-23 11:00:49 +0000
> +++ src/network/network.h 2019-04-28 14:30:33 +0000
> @@ -181,6 +181,11 @@
> };
>
> struct NetTransferFile {
> + NetTransferFile() : bytes(0), filename(""), md5sum("") {
> + }
> + ~NetTransferFile() {
> + parts.clear();
That extra clear(() does not make any difference
> + }
> uint32_t bytes;
> std::string filename;
> std::string md5sum;
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1826669-mp-map-b20/+merge/366619
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1826669-mp-map-b20 into lp:widelands/build20.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
