https://bugzilla.wikimedia.org/show_bug.cgi?id=19304
Roan Kattouw <roan.katt...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |roan.katt...@gmail.com
Status|REOPENED |RESOLVED
Resolution| |FIXED
--- Comment #4 from Roan Kattouw <roan.katt...@gmail.com> 2009-07-06 21:26:49
UTC ---
(In reply to comment #3)
> Also, using
> >function
> >JidanniLessRedContentActionsVectorSkin(&$a,&$links){var_dump($a,$links);die();return
> > true;}
> >$wgHooks['SkinTemplateNavigation'][]='JidanniLessRedContentActions';
> I was shocked to find in $links that local language strings have crept
> into variable names themselves, at the markers @@1@@, and @@3@@, that I
> put in below:
Trevor has fixed this in r52806.
> Now finally returning to the original topic of this bug. If the two
> skins could use the same hook, that would be great I suppose...
>
> OK, each should have its own hook, but users will dare to do
> $wgHooks['SkinTemplateTabs'][]=$wgHooks['SkinTemplateNavigation'][]='MyFunction';
> so there should be some statement about how safe that is.
>
The formats are not compatible, so it's not safe to assume they are. Using one
function that somehow still differentiates between them is safe as long as you
do it right.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
