| mobrovac added a comment. |
Nginx and Varnish already attach the X-Client-IP header to incoming requests (cf. this sample request), so all you have to do is actually use the provided header.
In T200594#4467019, @Mholloway wrote:It would be very easy to add the requesting IP to the user-agent string.
I believe this violates multiple privacy policies we have in place, but as stated above, work-arounds are not even needed.
Does WDQS have an internal URI (similar to restbase.svc.codfw.wmnet) that we could/should use in production? Currently we're hard-coding the public endpoint.
Yes. there are two WDQS cluster: an external and an internal one. The former services external requests coming from query.wikidata.org, while the latter is to be used for requests originating from entities inside our production environment. Therefore, Kartotherian should use http://wdqs-internal.discovery.wmnet - the internal cluster.
Cc: mobrovac, MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, debt, JGirault, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
