| mobrovac added a comment. |
In T200594#4469670, @Smalyshev wrote:Yes, but we need it to be the IP of the client of Karthoterian, not the IP of the server running Karthoterian.
Aren't clients making requests to Kartotherian? If they are, then X-Client-IP will be set to the external (to our prod environment) client issuing the request.
Why do you think so? WDQS is an internal WMF service, and the webrequest logs track incoming IPs anyway. So no additional information is logged and no PII is sent out.
This may constitute data manipulation not allowed by current policies. But, I am not an expert in this field, I just raised it as a potential legal problem. On the technical side, though, changing the UA for every client is IMHO a bad practice and should not even be considered a solution here.
Not sure about that, since Kartotherian is acting as a proxy in this case - i.e. we have load generated by public requests driven by the clients everywhere, and queries written by the clients, not just internal WMF workloads with queries curated by us, as far as I can understand. I'd prefer using internal clusters only for curated queries for now, unless Kartotherian load is very small.
There is precedent for this: the recommendation api service uses the internal WDQS cluster and issues requests to it upon receiving client requests. However, the requests sent to WDQS are strictly bounded (i.e. external clients cannot make arbitrary queries to WDQS). If that is the case with Katotherian as well, then the same principle can be applied. The original idea of the internal WDQS cluster was that internal services requiring it should function regardless of the external client load faced by WDQS directly.
But we do not need to uniquely identify a single request. We need to identify a client, sending multiple requests. That's the whole point of throttling.
It wasn't clear enough to me from the task desc that throttling is the main purpose of this.
Cc: mobrovac, MSantos, Gehel, Aklapper, MaxSem, Pnorman, Mholloway, Smalyshev, Amatissart, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Orienteerix, merbst, LawExplorer, debt, JGirault, Jonas, phabyogi, Xmlizer, Susannaanas, lxbarth, Eevans, jkroll, Planemad, Hardikj, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Yurik, Jdforrester-WMF, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
