| Tgr added a comment. |
Went through the high and medium priority steps of the test plan.
- MobileFrontend diffs break (use TextSlotDiffRenderer instead of InlineDifferenceEngine). MobileFrontend hand-creates the InlineDiffRenderer so it does not get used for the main slot; I don't think the diff patch can be improved to prevent that from happening (DifferenceEngine::getSlotDiffRenderers() could check its own class and replace TextSlotDiffRenderers with itself when it's not the base class, but that's scary and would probably break way more things). It needs to be fixed in MobileFrontend (and other extensions using a similar pattern).
- Diffing with non-existent old revisions is somewhat broken due to a previous patch (T201218: Viewing page's first revision via diff gives error).
- There are a bunch of callers which pass in a content object so non-main slots get ignored (edit conflict, for example). I think that's outside scope (better to keep patches small when possible) but should be tracked and eventually converted.
- I get an exception when I try to make a Wikibase slot in a non-Wikibase namespace. I think that's expected.
- Couldn't figure out what "diff should reflect user language" for Wikibase means.
- Could not test VisualEditor (npm has random failures, probably because it hogs up all the memory and gets killed, and I haven't found a good way to detect or repair broken installs). Will have to test it on Beta.
In short, I think the diff patch is OK, but MobileFrontend needs to be updated first to use a diff engine customization method that core can understand.
TASK DETAIL
EMAIL PREFERENCES
To: Tgr
Cc: pmiazga, Aklapper, gerritbot, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg
Cc: pmiazga, Aklapper, gerritbot, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
