| Tgr added a comment. |
In T194731#4498690, @daniel wrote:We'll need a ticket for that, and we need to figure out who can do this, and when.
T201842: Use ContentHandler to obtain DifferenceEngine in MobileFrontend
How urgent is this? Do I understand correctly that this causes fatal errors when clicking certain links on the live site?
No, it invokes DifferenceEngine's error handling (whereas previously these pages were special-cased to not show error messages). I added examples to T201218: Viewing page's first revision via diff gives error. The difference is not huge so I don't think it is super urgent.
I agree, but then we need a task for this. Can probably go on the MCR backlog pile, doesn't block SDC -- unless one of these things that pass Content objects needs to work with SDC.
T201848: Make DifferenceEngine callers pass revisions, not contents
Wikibase diffs should be rendered in the user language. This mainly affects value rendering: labels of referenced items, number format, etc. Probably not relevant for diffs of label or description.
Yeah, I actually did figure out in the last moment (and it worked), just forgot to update the comment.
Cc: pmiazga, Aklapper, gerritbot, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
